[MYFACES-3150] [perf] buildView: review usage of "facelets.FACET_NAME"

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0-SNAPSHOT
• Fix Version/s: 2.0.13, 2.1.7
• Component/s: General
• Environment: myfaces core trunk
• Assignee: Leonardo Uribe
• Reporter: Martin Kočí
• Created: 16/May/11 16:50
• Updated: 03/Apr/12 18:39
• Resolved: 07/Mar/12 20:11

Description

Consider 1000 components in view without any f:facet.

During VDL.buildView Facelets call for each component ComponentHandler.getFacetName(FaceletContext, UIComponent) and that creates 3 calls of Map.get():

1) _ComponentAttributesMap.getPropertyDescriptor(String)
2) _ComponentAttributesMap.getUnderlyingMap().get()
3) UIComponent.getValueExpression(String)

3000 "empty" invocations in buildView withnout match.

Suggestions:

• do not use Component.attribute for that marker (comes from FacetHandler)
• replace map.get calls with property for performance reasons
• use a stack or property on AbstractFaceletContext if possible