Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.6, 2.1.0
    • Component/s: JSR-314
    • Labels:
      None

      Description

      It is necessary to do some cleanup and add more junit tests to state saving code in MyFaces.

      For PSS code, we just copied some parts of the original algorithm found on JspStateManagerImpl because just PSS was a very challenging task and the intention was prevent break existing code.

      But now we have a stable code in this part, so it is the right moment to do some cleanup and then change the code to fit user's needs.

      1. MYFACES-3134-2.patch
        87 kB
        Leonardo Uribe

        Activity

        Hide
        Martin Kočí added a comment -

        I think that suspicious lines:

        if (log.isLoggable(Level.FINEST)) log.finest("Calling saveView of StateManagementStrategy from getViewState: "+sms.getClass().getName());
        return facesContext.getRenderKit().getResponseStateManager().getViewState(facesContext, saveView(facesContext));

        in org.apache.myfaces.application.jsp.JspStateManagerImpl.getViewState(FacesContext), line 617

        breaks PPS - there must be

        if (sms != null)

        { savedState = (Object[]) sms.saveView(facesContext); }
        Show
        Martin Kočí added a comment - I think that suspicious lines: if (log.isLoggable(Level.FINEST)) log.finest("Calling saveView of StateManagementStrategy from getViewState: "+sms.getClass().getName()); return facesContext.getRenderKit().getResponseStateManager().getViewState(facesContext, saveView(facesContext)); in org.apache.myfaces.application.jsp.JspStateManagerImpl.getViewState(FacesContext), line 617 breaks PPS - there must be if (sms != null) { savedState = (Object[]) sms.saveView(facesContext); }
        Hide
        Leonardo Uribe added a comment -

        Note JspStateManagerImpl will be replaced by org.apache.myfaces.application.StateManagerImpl. There are some changes to do in this part, but the details will be discussed on myfaces dev list.

        Show
        Leonardo Uribe added a comment - Note JspStateManagerImpl will be replaced by org.apache.myfaces.application.StateManagerImpl. There are some changes to do in this part, but the details will be discussed on myfaces dev list.

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development