Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None

      Description

      See http://www.mail-archive.com/dev@myfaces.apache.org/msg50721.html

      And from http://wiki.java.net/bin/view/Projects/Jsf2RequirementsScratchpad:

      Better Error reporting, like what you get with Tapestry (also in
      JSR-252-EG, where it was said: any time there is an error in any
      part of the lifecycle, the user should see not just a cryptic stack
      trace, but also the component - including file and line number - that
      triggered the problem, the EL expression that was being evaluated -
      including the part of the EL expression that triggered the problem,
      etc. Diagnosability for state saving is also important. On this point,
      Gavin King wants to have centralized error handling, with an
      interception point, perhaps using navigation rules, to help handle
      errors.)

        Activity

        Hide
        Leonardo Uribe added a comment -

        Added some bug fixes and enhancements:

        • Fix Ajax case and myfaces error handling disabled.
        • Add MyFacesExceptionHandlerWrapperImpl and remove ErrorPageWriter.handleThrowable try/catch blocks, this solves MYFACES-3193
        • Output multiple exception stack traces
        • Disable MyFaces exception handling if Project Stage is not development. Before, it was enabled in stages like Production, but this is not wanted to comply with JSF 2.0 spec (Mojarra disables it too). In this way, it should be enabled in a explicit way in production.
        • Remove ErrorPageWriter.handleThrowable block from ResourceHandler implementation, because there is no view there and is not meaningful in such situation (serve html when text/css or text/javascript is expected doesn't sounds good).
        Show
        Leonardo Uribe added a comment - Added some bug fixes and enhancements: Fix Ajax case and myfaces error handling disabled. Add MyFacesExceptionHandlerWrapperImpl and remove ErrorPageWriter.handleThrowable try/catch blocks, this solves MYFACES-3193 Output multiple exception stack traces Disable MyFaces exception handling if Project Stage is not development. Before, it was enabled in stages like Production, but this is not wanted to comply with JSF 2.0 spec (Mojarra disables it too). In this way, it should be enabled in a explicit way in production. Remove ErrorPageWriter.handleThrowable block from ResourceHandler implementation, because there is no view there and is not meaningful in such situation (serve html when text/css or text/javascript is expected doesn't sounds good).
        Hide
        Martin Kočí added a comment -

        I will commit some patches for this area - but only new classes for the new exception handling and logging infrastructure. If change in current codebase needed, I'll attach it as patch for discussion first. When we resolve this issue completely, we can backport result to 2.0 branch.

        Show
        Martin Kočí added a comment - I will commit some patches for this area - but only new classes for the new exception handling and logging infrastructure. If change in current codebase needed, I'll attach it as patch for discussion first. When we resolve this issue completely, we can backport result to 2.0 branch.

          People

          • Assignee:
            Unassigned
            Reporter:
            Martin Kočí
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development