MyFaces Core
  1. MyFaces Core
  2. MYFACES-3034

ui:repeat offset and size performs incorrect validation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.8, 2.1.2
    • Component/s: General
    • Labels:
      None
    • Environment:
      OpenJDK 1.6.0_20; Tomcat 6.0.20; Ubuntu 10.04 on kernel version 2.6.32-28-generic

      Description

      The following ui:repeat tag with those values of size and offset throw a FacesException with the message: "iteration offset cannot be greater than collection size."

      <ui:repeat var="listing" value="#

      {myListings.listings}

      " size="19" offset="20">

      It appears that the method _validateAttributes() in the UIRepeat class performs the validation incorrectly. It seems to assume that the value of size is the size of the collection, rather than the desired iteration size. Here is the relevant code from _validateAttributes():

      if ((size > -1) && (begin > size))

      { throw new FacesException ("iteration offset cannot be greater " + "than collection size"); }

      The exception is thrown in the above case because begin > size, where begin = offset = 20.

        Issue Links

          Activity

          Rey Dalisay created issue -
          Leonardo Uribe made changes -
          Field Original Value New Value
          Link This issue is duplicated by MYFACES-3183 [ MYFACES-3183 ]
          Leonardo Uribe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Leonardo Uribe [ lu4242 ]
          Fix Version/s 2.0.8 [ 12316514 ]
          Fix Version/s 2.1.2 [ 12316512 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Leonardo Uribe made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Leonardo Uribe
              Reporter:
              Rey Dalisay
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development