[MYFACES-3033] Improve DebugPhaseListener for UIData and SKIP_ITERATION

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.1.0
• Component/s: General
• Assignee: Martin Kočí
• Reporter: Martin Kočí
• Created: 07/Feb/11 11:06
• Updated: 04/Apr/12 01:24
• Resolved: 14/Feb/12 19:58

Description

<h:dataTable var="row" >
<h:column>
<h:outputText rendered="#

{bean.isRendered(row)}

"

There is new VisitHint.SKIP_ITERATION in JSF 2.1. If that hint is used UIData iterate over children in "flat" manner and therefore no row is available - bean.isRendered(row) obtains null as parameter and NPE can happen. One problem in this situation is a component tree walk before RESTORE_VIEW from DebugPhaseListener:

java.lang.NullPointerException
foo.bazz.bean.isRendered
...
at org.apache.myfaces.view.facelets.el.TagValueExpression.getValue(TagValueExpression.java:85)
at javax.faces.component._DeltaStateHelper.eval(_DeltaStateHelper.java:260)
at javax.faces.component.UIComponentBase.isRendered
...
at javax.faces.component.UIComponentBase.visitTree(UIComponentBase.java:991)
at org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener._doTreeVisit(DebugPhaseListener.java:310)
at org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener.afterPhase(DebugPhaseListener.java:286)