[MYFACES-2928] FacesConfigurator cast for ApplicationImpl directly to load converter configuration, instead use RuntimeConfig object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.9-SNAPSHOT, 1.2.10-SNAPSHOT, 2.0.3-SNAPSHOT
• Fix Version/s: 1.1.9, 1.2.10, 2.0.3
• Component/s: JSR-314
• Assignee: Leonardo Uribe
• Reporter: Leonardo Uribe
• Created: 23/Sep/10 23:41
• Updated: 05/Feb/11 20:28
• Resolved: 24/Sep/10 00:42

Description

Checking some code on myfaces I notice this lines on FacesConfigurator:

if(application instanceof ApplicationImpl)
{
for (Iterator it = _dispenser.getConverterConfigurationByClassName(); it.hasNext()

{ String converterClassName = (String) it.next(); ((ApplicationImpl) application).addConverterConfiguration(converterClassName, _dispenser.getConverterConfiguration(converterClassName)); }

}

We should avoid that, and instead use RuntimeConfig object, because that is the right place to do that.

The problem with this hack is what happen when Application object is wrapped. It is very rare that someone overrides this class, but on JSF 2.0 this problem become important, because it is valid to wrap Application object.

The solution is just move the related code to RuntimeConfig object and call from ApplicationImpl doing a lookup to that location.