MyFaces Core
  1. MyFaces Core
  2. MYFACES-2904

javascript _Dom._outerHtml does not handle table items (<tr>, <tbody>. ...)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: JSR-314
    • Labels:
      None

      Description

      Checking some stuff in tomahawk, I found that when a fragment starts with <tr> or some tag that should be used inside <table> are trimmed when are replaced on an ajax request.

        Activity

        Hide
        Werner Punz added a comment -

        ok I gave the fixup code now a testrun, leos code with my fixes now work perfectly.
        The Sieve test does not show any problems. Seems like the fix works.
        Also table element replacement now seems to work like a charm.
        Thanks Leo for providing the fix.

        Show
        Werner Punz added a comment - ok I gave the fixup code now a testrun, leos code with my fixes now work perfectly. The Sieve test does not show any problems. Seems like the fix works. Also table element replacement now seems to work like a charm. Thanks Leo for providing the fix.
        Hide
        Werner Punz added a comment -

        Ok sorry for the delay, but I was bound by customer projects, I reevaluated the code, there were bugs in the ie part of things, I cleaned up the code it should work now, I will commit my working codebase, but the table part needs further testing on my side.

        Show
        Werner Punz added a comment - Ok sorry for the delay, but I was bound by customer projects, I reevaluated the code, there were bugs in the ie part of things, I cleaned up the code it should work now, I will commit my working codebase, but the table part needs further testing on my side.
        Hide
        Werner Punz added a comment -

        No problem thanks for merging it in, I am currently bound by customer projects so I would not have had time before next week to do it. I will give it a final testing next week to make sure the code is waterproof but from a first look it looked very good to me.

        Show
        Werner Punz added a comment - No problem thanks for merging it in, I am currently bound by customer projects so I would not have had time before next week to do it. I will give it a final testing next week to make sure the code is waterproof but from a first look it looked very good to me.
        Hide
        Leonardo Uribe added a comment -

        Ok, thanks Werner for check this one.

        Show
        Leonardo Uribe added a comment - Ok, thanks Werner for check this one.
        Hide
        Jakob Korherr added a comment -

        great stuff

        Show
        Jakob Korherr added a comment - great stuff
        Hide
        Werner Punz added a comment -

        Wow now this is a nice patch, I never intented the outerHTML to be used this way and yes there are problems with IE. All I can say is wow... go ahead and commit it otherwise I will do
        Really nice stuff, thanks for doing it, I guess we now have a kickass outerHTML function.

        Show
        Werner Punz added a comment - Wow now this is a nice patch, I never intented the outerHTML to be used this way and yes there are problems with IE. All I can say is wow... go ahead and commit it otherwise I will do Really nice stuff, thanks for doing it, I guess we now have a kickass outerHTML function.

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development