MyFaces Core
  1. MyFaces Core
  2. MYFACES-2889

[PERF] Remove String.intern() calls in FlashELResolver and ImplicitObjectResolver

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-SNAPSHOT
    • Fix Version/s: 1.2.11, 2.0.8, 2.1.2
    • Component/s: JSR-314
    • Labels:
      None
    • Environment:
      JBoss AS 6 M4, Parleys.com JSF2 app

      Description

      I've been doing some profiling and I see pretty much activity in FlashELResolver.castAndIntern() and ImplicitObjectResolver.castAndIntern().
      When I replace the "return s.intern()" lines by "return s", both methods have (of course) much better performance.

      But I'm pretty sure someone put them there with a reason, like memory footprint.
      However, I don't see any difference in memory footprint.

      Any ideas? Do we want to keep the intern() calls?

        Issue Links

          Activity

          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Leonardo Uribe made changes -
          Fix Version/s 1.2.11 [ 12316650 ]
          Leonardo Uribe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Leonardo Uribe [ lu4242 ]
          Fix Version/s 2.0.8 [ 12316514 ]
          Fix Version/s 2.1.2 [ 12316512 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Field Original Value New Value
          Link This issue is part of MYFACES-1618 [ MYFACES-1618 ]
          Jan-Kees van Andel created issue -

            People

            • Assignee:
              Leonardo Uribe
              Reporter:
              Jan-Kees van Andel
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development