MyFaces Core
  1. MyFaces Core
  2. MYFACES-2858

pointless oamsubmit inline rendering (patch available)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-SNAPSHOT
    • Fix Version/s: 2.0.2
    • Component/s: None
    • Labels:
      None

      Description

      We have had several functions rendered inline for ages, namely appendHiddenInput oamSubmit, the autoscroll stuff etc...
      I personally think the rendering of those functions as inline scripts is pointless, blows up the browsers tremendously and
      prevents that the affected scripts can be browser cached.
      A quick look at the code revealed that there is basically nothing which would prevent to externalize the scripts. My main problem is where to we handle the auto append code.
      My personal guess is we probably simply should add it as a resource definitions to the commandLink, Button etc.. renderers, any ideas regarding this?

        Activity

        Werner Punz created issue -
        Werner Punz made changes -
        Field Original Value New Value
        Attachment https___issues_apache_org_jira_browse_MYFACES-2858_externalizing_oamsubmit__.patch [ 12451572 ]
        Werner Punz made changes -
        Summary pointless oamsubmit inline rendering pointless oamsubmit inline rendering (patch available)
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Jakob Korherr made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.2-SNAPSHOT [ 12315118 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Jakob Korherr made changes -
        Assignee Jakob Korherr [ jakobkorherr ]
        Jakob Korherr made changes -
        Attachment MYFACES-2858-2.patch [ 12452279 ]
        Jakob Korherr made changes -
        Status Reopened [ 4 ] Patch Available [ 10002 ]
        Jakob Korherr made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Leonardo Uribe made changes -
        Fix Version/s 2.0.2 [ 12315348 ]
        Fix Version/s 2.0.2-SNAPSHOT [ 12315118 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jakob Korherr
            Reporter:
            Werner Punz
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development