MyFaces Core
  1. MyFaces Core
  2. MYFACES-2751

escape attribute of h:outputLabel is not picked up by HtmlLabelRenderer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.8
    • Fix Version/s: 1.2.10
    • Component/s: General
    • Labels:
      None

      Description

      specifying the escape attribute on the outputLabel has no effect. The renderer always does an encoding of the value.

      Only verified with version 1.2.8. (1.1 and/or 2.0) could have the same problem.

      1. LabelEscapeTest.java
        3 kB
        Rudy De Busscher
      2. myfaces-2751.patch
        1.0 kB
        Rudy De Busscher

        Issue Links

          Activity

          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Leonardo Uribe made changes -
          Fix Version/s 1.2.10 [ 12315978 ]
          Fix Version/s 1.2.10-SNAPSHOT [ 12315114 ]
          Jakob Korherr made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 1.2.10-SNAPSHOT [ 12315114 ]
          Resolution Fixed [ 1 ]
          Hide
          Jakob Korherr added a comment -

          committed fix for 1.2 and test case for 1.2 and 2.0

          Show
          Jakob Korherr added a comment - committed fix for 1.2 and test case for 1.2 and 2.0
          Hide
          Jakob Korherr added a comment -

          MYFACES-2416 handles this issue for MyFaces 2.0.x.

          But you're right Rudy, the issue also exists in 1.2. For JSF 1.1 however, there is no escape property for h:outputLabel (checked tld-doc of the RI).

          Show
          Jakob Korherr added a comment - MYFACES-2416 handles this issue for MyFaces 2.0.x. But you're right Rudy, the issue also exists in 1.2. For JSF 1.1 however, there is no escape property for h:outputLabel (checked tld-doc of the RI).
          Jakob Korherr made changes -
          Link This issue is related to MYFACES-2416 [ MYFACES-2416 ]
          Jakob Korherr made changes -
          Assignee Jakob Korherr [ jakobkorherr ]
          Rudy De Busscher made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rudy De Busscher made changes -
          Attachment myfaces-2751.patch [ 12446979 ]
          Hide
          Rudy De Busscher added a comment -

          patch for 1.2.8/myfaces-impl

          Show
          Rudy De Busscher added a comment - patch for 1.2.8/myfaces-impl
          Rudy De Busscher made changes -
          Field Original Value New Value
          Attachment LabelEscapeTest.java [ 12446978 ]
          Hide
          Rudy De Busscher added a comment -

          JUnit test that shows problem.

          Dependencies used in POM
          <dependency>
          <groupId>org.apache.myfaces.core</groupId>
          <artifactId>myfaces-api</artifactId>
          <version>1.2.8</version>
          </dependency>
          <dependency>
          <groupId>org.apache.myfaces.core</groupId>
          <artifactId>myfaces-impl</artifactId>
          <version>1.2.8</version>
          </dependency>
          <dependency>
          <groupId>junit</groupId>
          <artifactId>junit</artifactId>
          <version>4.3.1</version>
          <scope>test</scope>
          </dependency>
          <dependency>
          <groupId>org.apache.myfaces.test</groupId>
          <artifactId>myfaces-test12</artifactId>
          <version>1.0.0-beta-4</version>
          <scope>test</scope>
          </dependency>
          <dependency>
          <groupId>javax.servlet</groupId>
          <artifactId>servlet-api</artifactId>
          <version>2.5</version>
          <scope>test</scope>
          </dependency>

          Show
          Rudy De Busscher added a comment - JUnit test that shows problem. Dependencies used in POM <dependency> <groupId>org.apache.myfaces.core</groupId> <artifactId>myfaces-api</artifactId> <version>1.2.8</version> </dependency> <dependency> <groupId>org.apache.myfaces.core</groupId> <artifactId>myfaces-impl</artifactId> <version>1.2.8</version> </dependency> <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> <version>4.3.1</version> <scope>test</scope> </dependency> <dependency> <groupId>org.apache.myfaces.test</groupId> <artifactId>myfaces-test12</artifactId> <version>1.0.0-beta-4</version> <scope>test</scope> </dependency> <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> <version>2.5</version> <scope>test</scope> </dependency>
          Rudy De Busscher created issue -

            People

            • Assignee:
              Jakob Korherr
              Reporter:
              Rudy De Busscher
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development