[MYFACES-2737] Cache FacesContext on UIComponentBase instances

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.1.8, 1.2.9, 2.0.1
• Component/s: JSR-314
• Assignee: Leonardo Uribe
• Reporter: Leonardo Uribe
• Created: 27/May/10 01:19
• Updated: 07/Jun/10 01:53
• Resolved: 28/May/10 02:28

Description

Right now, the implementation of UIComponentBase.getFacesContext() is this:

@Override
protected FacesContext getFacesContext()

{ return FacesContext.getCurrentInstance(); }

I think it is possible to create a variable like this:

private transient FacesContext _facesContext;

and change the current implementation to:

void setCachedFacesContext(FacesContext facesContext)

{ _facesContext = facesContext; }

@Override
protected FacesContext getFacesContext()
{
if (_facesContext == null)

{ return FacesContext.getCurrentInstance(); }

else

{ return _facesContext; }

}

Then we do this on methods like processXXX, encodeXXX (not on encodeAll), visitTree and invokeOnComponent:

@Override
public void processDecodes(FacesContext context)
{
try

{ setCachedFacesContext(context); /*...... do what is required ........*/ }

finally

{ popComponentFromEL(context); setCachedFacesContext(null); }

In few words, set and release temporally the variable while those operations are executed. This change will reduce the amount of calls to FacesContext.getCurrentInstance() without side effects, because we are caching only on safe places and enclosing everything in a try finally block.

If no objections I'll commit this code soon.