Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.7, 1.2.8, 2.0.0
    • Fix Version/s: 1.1.8, 1.2.9, 2.0.1
    • Component/s: None
    • Labels:
      None

      Description

      Discussing some extval stuff, it was found myfaces always try to retrieve the renderkit factory to get the current renderkit, ignoring the method FacesContext.getRenderKit().

      FacesContext implementation cache a renderkit factory instance and on that place we could cache the current renderkit too. Doing some tests with extval on mojarra we discover that it creates very few instances (between 2 to 4) and myfaces creates many of them, because extval renderkit create wrappers over and over and myfaces does not cache them.

      In theory, the renderkit instance used is per view, so in a single request it is expected this instance changes by most twice. I think we should commit this change on all branches (1.1.x, 1.2.x and 2.0.x).

        Activity

        Leonardo Uribe created issue -
        Leonardo Uribe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.1.8-SNAPSHOT [ 12314016 ]
        Fix Version/s 1.2.9-SNAPSHOT [ 12314391 ]
        Fix Version/s 2.0.1-SNAPSHOT [ 12314891 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.8 [ 12315115 ]
        Fix Version/s 1.2.9 [ 12315113 ]
        Fix Version/s 2.0.1 [ 12315117 ]
        Fix Version/s 1.1.8-SNAPSHOT [ 12314016 ]
        Fix Version/s 1.2.9-SNAPSHOT [ 12314391 ]
        Fix Version/s 2.0.1-SNAPSHOT [ 12314891 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development