MyFaces Core
  1. MyFaces Core
  2. MYFACES-2661

h:link render conversationContext param multiple times


    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta-3
    • Fix Version/s: 2.0.0
    • Component/s: JSR-314
    • Labels:
    • Environment:
      myfaces core + myfaces orchestra


      Doing some tests between myfaces core and orchestra I found that when h:link is rendered, the conversationContext param is rendered multiple times. It has two reasons:

      1. It is called ExternalContext.encodeResourceURL from the rendered, but before it was called ViewHandler.getBookmarkableURL (on HtmlRendererUtils.getOutcomeTargetLinkHref). We need to remove the call to encodeResourceURL, because it is not necessary.
      2. ExternalContext.encodeBookmarkableURL call _httpServletResponse.encodeURL and it should not. The reason is ViewHandler.getBookmarkableURL do this task calling ExternalContext.encodeActionURL.

      I think this one has enough importance to be included in 2.0.0 release, so I'll regenerate all artifacts to include this one. Note this effect is only detected when myfaces core and orchestra are used together, because orchestra override HttpServletResponse.encodeURL to add his conversationContext param.


        Leonardo Uribe created issue -
        Leonardo Uribe made changes -
        Field Original Value New Value
        Environment myfaces core + myfaces orchestra
        Leonardo Uribe made changes -
        Attachment MYFACES-2661-shared.patch [ 12441907 ]
        Attachment MYFACES-2661-core.patch [ 12441906 ]
        Leonardo Uribe made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0 [ 12314890 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        6m 57s 1 Leonardo Uribe 16/Apr/10 02:59
        Resolved Resolved Closed Closed
        20d 23h 7m 1 Leonardo Uribe 07/May/10 02:06


          • Assignee:
            Leonardo Uribe
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            0 Start watching this issue


            • Created: