[MYFACES-2548] META-INF resource lookup in OSGi environment

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-beta-2
• Fix Version/s: 2.0.0-beta-2
• Component/s: General
• Assignee: Jakob Korherr
• Reporter: Jarek Gawor
• Created: 11/Feb/10 05:01
• Updated: 02/May/13 02:29
• Resolved: 11/Feb/10 10:08

Description

MyFaces uses context class loader to lookup META-INF resources. This works fine in a regular Java environment but breaks in OSGi. One easy solution for this would be to first ask the CCL for the resource and if none is found ask the surrounding class class loader for that resource (assuming the resource we are looking for lives in the same jar as the class loading it), i.e.:

URL foo = getContextClassLoader().getResource("META-INF/foo");
if (foo == null) {
foo = getClass().getClassLoader().getResource("META-INF/foo");
}

There are a few places in MyFaces code that would need to be updated to use this fallback approach. For example in IncludeHandler.java and ErrorPageWriter.java.

I also noticed that for some reason the myfaces-dev-debug.xml and myfaces-dev-error.xml live in the api module. They seem to be only used the impl module so they shouldn't really be needed in the api module.

Issue Links

• is depended upon by: GERONIMO-4996 myfaces 2 osgi integration