MyFaces Core
  1. MyFaces Core
  2. MYFACES-2534

ComponentSupport.addFacet adds a panel when there is only one component as a child

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta-2
    • Fix Version/s: 2.0.0-beta-2
    • Component/s: JSR-314
    • Labels:
      None

      Description

      Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486

        Activity

        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jakob Korherr made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jakob Korherr added a comment -

        OK good

        Show
        Jakob Korherr added a comment - OK good
        Hide
        Leonardo Uribe added a comment -

        I think the comment there is referred to f:metadata behavior. We ensure that in ViewMetadataHandler, so it is ok.

        Show
        Leonardo Uribe added a comment - I think the comment there is referred to f:metadata behavior. We ensure that in ViewMetadataHandler, so it is ok.
        Hide
        Jakob Korherr added a comment -

        Good point. But when I implemented this for myfaces I tested this scenario with RI and they really created an UIPanel for one component. Maybe they changed this behavior...

        Another undocumented change. Yippee!

        Show
        Jakob Korherr added a comment - Good point. But when I implemented this for myfaces I tested this scenario with RI and they really created an UIPanel for one component. Maybe they changed this behavior... Another undocumented change. Yippee!
        Hide
        Leonardo Uribe added a comment -

        I don't believe ri is doing that, because if so, why t:tree2 works with tomahawk (it should throw the same error and in the real example it is not)? Instead, I think this is an error on the spec.

        Show
        Leonardo Uribe added a comment - I don't believe ri is doing that, because if so, why t:tree2 works with tomahawk (it should throw the same error and in the real example it is not)? Instead, I think this is an error on the spec.
        Jakob Korherr made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Jakob Korherr added a comment -

        Leonardo,

        As I told you earlier on MYFACES-2435, the spec says that every child of the facet has to be an UIPanel:

        " [...] The implementation must ensure that the direct child of the facet is a UIPanel, even if there is only one child of the facet. [...]"

        So please roll back the changes and change the tomahawk components instead!

        Show
        Jakob Korherr added a comment - Leonardo, As I told you earlier on MYFACES-2435 , the spec says that every child of the facet has to be an UIPanel: " [...] The implementation must ensure that the direct child of the facet is a UIPanel, even if there is only one child of the facet. [...] " So please roll back the changes and change the tomahawk components instead!
        Leonardo Uribe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0-beta-2 [ 12314539 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe created issue -

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Leonardo Uribe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development