Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-2493

ViewMetadata facelets compiler should not output DTD, <?xml or any UIInstruction outside f:metadata

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0-alpha
    • 2.0.0-beta
    • JSR-314
    • None

    Description

      This does not have any side effects but originally, FaceletViewHandler used this line on renderView method:

      // build view - but not if we're in "buildBeforeRestore"
      // land and we've already got a populated view. Note
      // that this optimizations breaks if there's a "c:if" in
      // the page that toggles as a result of request processing -
      // should that be handled? Or
      // is this optimization simply so minor that it should just
      // be trimmed altogether?
      if (!this.buildBeforeRestore || viewToRender.getChildren().isEmpty())

      { this.buildView(context, viewToRender); }

      Since we need to solve MYFACES-2483 Find a way to allow c:if work with partial state saving enabled, we need a way to detect when a view is "updated", and check if UIViewRoot has children is ideal.

      Attachments

        Activity

          People

            lu4242 Leonardo Uribe
            lu4242 Leonardo Uribe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: