[MYFACES-2144] <render-kit> parsing problem

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.7-SNAPSHOT
• Fix Version/s: 1.2.7
• Assignee: Bernd Bohmann
• Reporter: Val Blant
• Created: 05/Feb/09 00:00
• Updated: 01/Jun/09 07:54
• Resolved: 10/Feb/09 21:28

Description

There is a small error in DigesterFacesConfigDispenserImpl.feed() method.

In the for-loop responsible for storing the render kits, when no render kit id was specified in the file being parsed (i.e. renderKit.getId() is null), we default the render kit id to "HTML_BASIC". Later we store the render kit in a map (renderKits), with key being the render kit id. However, the code erroneously uses null as the key, instead of "HTML_BASIC". This, of course, breaks FacesConfigurator.configureRenderKits() once it tries to add a render kit with a 'null' id.

I suspect that the reason for this bug going unnoticed until now is that the 'null' key will only be used if the FIRST <render-kit> found on the class path does not specify an explicit id. All subsequent <render-kit> declarations are merged into the element with the correct key (HTML_BASIC), which is why it works as long as the first <render-kit> has an id.

I'm uploading a patch with a fix for this bug.