[MYFACES-1897] escape value of a selectItem is never evaluated

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.3
• Fix Version/s: 1.2.4
• Component/s: JSR-252
• Assignee: Leonardo Uribe
• Reporter: Jörg Rothbarth
• Created: 14/Jul/08 11:00
• Updated: 27/Aug/08 01:30
• Resolved: 11/Aug/08 21:02

Description

The escape Attribute of a selectItem Component is not evaluated inside a selectOneRadio component.
The selectItem Component has a escape member, but the member is never used.

To fix the problem i've done this:

HtmlRadioRendererBase.renderGroupOrItemRadio() Line ~199 :

// label element after the input
boolean componentDisabled = isDisabled(facesContext, selectOne);
boolean disabled = (componentDisabled || itemDisabled);
boolean escape = selectItem.isEscape();

HtmlRendererUtils.renderLabel(writer, selectOne, itemId,
selectItem.getLabel(), disabled,escape);

HtmlRendererUtils.renderLabel() Line ~1352:

public static void renderLabel(ResponseWriter writer, UIComponent
component, String forClientId,String labelValue, boolean
disabled) throws IOException {
renderLabel(writer, component, forClientId, labelValue, disabled, true);
}

/**

• Renders a label HTML element
  */
  public static void renderLabel(ResponseWriter writer, UIComponent
  component, String forClientId,String labelValue, boolean disabled, boolean escape) throws IOException {

...

if ((labelValue != null) && (labelValue.length() > 0)) {
writer.write(HTML.NBSP_ENTITY);
if (escape)

{ writer.writeText(labelValue, null); }

else

{ writer.write(labelValue); }

}
...