MyFaces Core
  1. MyFaces Core
  2. MYFACES-1896

FacesConfigurator version check incorrect

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.2.8
    • Component/s: None
    • Labels:
      None

      Description

      The FacesConfigurator does some checks on whether there are multiple versions of Tomahawk and MyFaces in the classpath. This check is incorrect, in the sense that it can, and will, log incorrect error messages.

      This problem occurs when using the jar from the tomahawk-facelets project (http://code.google.com/p/tomahawk-facelets), of which I'm one of the maintainers. The current release is called tomahawk-facelets-1.1.6.2.jar, which gives the following error:

      ERROR FacesConfigurator?:404 - You are using the MyFaces?-package : tomahawk in different versions; first (and probably used) version is : 1.1.6, currently encountered version is : facelets-taglib. This will cause undesired behaviour. Please clean out your class-path. The first encountered version is loaded from : file:/G:/Development/IdeaProjects/blokart/out/exploded/blokartWeb/WEB-INF/lib/tomahawk-1.1.6.jar. The currently encountered version is loaded from : jar:file:/G:/Development/IdeaProjects/blokart/out/exploded/blokartWeb/WEB-INF/lib/tomahawk-facelets-taglib.jar!/META-INF/MANIFEST.MF

      However, this jar just contains taglibs and some supporting class files. So the error is logged without a valid reason.

      I've looked at the code in the FacesConfigurator and have seen that the checks can be improved, e.g. using the following regular expression for getting the version number of Tomahawk: tomahawk-(\d\.\d\.\d)

      1. MYFACES-1896.patch
        21 kB
        Simon-Pierre Béliveau
      2. MYFACES-1896-v2.patch
        22 kB
        Simon Lessard

        Activity

        Leonardo Uribe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.2.8 [ 12314390 ]
        Fix Version/s 1.2.8-SNAPSHOT [ 12314014 ]
        Leonardo Uribe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Leonardo Uribe [ lu4242 ]
        Fix Version/s 1.2.8-SNAPSHOT [ 12314014 ]
        Resolution Fixed [ 1 ]
        Simon Lessard made changes -
        Attachment MYFACES-1896-v2.patch [ 12390319 ]
        Simon-Pierre Béliveau made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Simon-Pierre Béliveau made changes -
        Field Original Value New Value
        Attachment MYFACES-1896.patch [ 12388638 ]
        Hilbert Schraal created issue -

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Hilbert Schraal
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development