MyFaces Core
  1. MyFaces Core
  2. MYFACES-1871

UIInput throws IllegalArgumentException for unknown event types in broadcast()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.5, 1.2.2
    • Fix Version/s: 1.1.6
    • Component/s: General
    • Labels:
      None
    • Environment:
      MyFaces Core 1.2.2

      Description

      broadcast() method of UIComponent should threw IllegalArgumentException if the implementation class of event argument was not supported by the component in JSF 1.1

      It seems that there is no such requirement in JSF 1.2 standard, but UIInput still checks for ValueChangeEvent type and throws exception if it so not so. That enforces component developers not to call super.broadcast in UIInput-derived components

        Activity

        Hide
        Leonardo Uribe added a comment -

        Do not allow any other events different to ValueChangeEvent be driven by UIInput is bad. The change done was to remove this checking and add a cast to check if the event is an instance of ValueChangeEvent, to delegate to the proper code

        Show
        Leonardo Uribe added a comment - Do not allow any other events different to ValueChangeEvent be driven by UIInput is bad. The change done was to remove this checking and add a cast to check if the event is an instance of ValueChangeEvent, to delegate to the proper code

          People

          • Assignee:
            Leonardo Uribe
            Reporter:
            Nick Belaevski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development