Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.1-SNAPSHOT
    • Fix Version/s: 1.2.2
    • Component/s: None
    • Labels:
      None

      Description

      Last week I did some JMeter testing, profiling and code checking on MyFaces to try increase the overall performance. Here are my suggestions for improvement:

      *) _ComponentAttributesMap
      I introduced a cache for maps with component attributes. This cache avoids rebuilding the map for every instance of the same component class. It is implemented using a WeakHashMap to allow the GC to remove entries that are not referenced in any instance.

      *) UIComponentBase
      Made a few changes in isIdValid as it is called quite often. The new id is now checked against the old id and if it is the same it is assumed as valid (avoids checking chars). Additionally I use isLetterOrDigit() and access string chars directly insted of fetching an array first.

      *) ImplicitObjectResolver
      I replaced List with Map to avoid iteration over lists.

      *) HtmlResponseWriterImpl
      Use new method of HTMLEncoder for char[]

      *) HTMLEncoder
      Improved performance of encode mthod and added a new one that takes a char[] und directly writes to a writer.

      *) UnicodeEncoder
      Replaced StringBuffer with StringBuilder.

        Issue Links

          Activity

          Hide
          Michael Kurz added a comment -

          Patch with performance related changes.

          Show
          Michael Kurz added a comment - Patch with performance related changes.
          Hide
          Martin Marinschek added a comment -

          Thanks to Michael Kurz for this important patch.

          regards,

          Martin

          Show
          Martin Marinschek added a comment - Thanks to Michael Kurz for this important patch. regards, Martin

            People

            • Assignee:
              Martin Marinschek
              Reporter:
              Michael Kurz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development