MyFaces Core
  1. MyFaces Core
  2. MYFACES-1735

Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      using tomahawk 1.1.6

      Description

      Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.

      Problem: Myfaces refuses to start.

      Expected behaviour: Myfaces should start.

      Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.

      In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
      public InputSource resolveEntity(...)
      {
      InputStream stream;
      if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))

      { stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE); }

      else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))

      { stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE); }

      ....
      }
      However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar

      Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar

        Activity

        Hide
        Thomas Fox added a comment -

        Set on "patch provided" because the necessary files are still in the myfaces repository

        Show
        Thomas Fox added a comment - Set on "patch provided" because the necessary files are still in the myfaces repository
        Hide
        Martin Marinschek added a comment -

        Hi Thomas,

        thanks for looking at this - should be fixed now.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hi Thomas, thanks for looking at this - should be fixed now. regards, Martin
        Hide
        Matt Raible added a comment -

        Any chance of getting 1.2.1 released this week to get this fix?

        Show
        Matt Raible added a comment - Any chance of getting 1.2.1 released this week to get this fix?

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Thomas Fox
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development