MyFaces Core
  1. MyFaces Core
  2. MYFACES-1688

Highlighting of component on error page

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1.6
    • Fix Version/s: 1.1.6
    • Component/s: General
    • Labels:
      None

      Description

      The patch just adds highlighting of the component that produced the error in the component tree

      1. error_handling-02-08.patch
        7 kB
        Sorin Silaghi
      2. sample-error.html
        22 kB
        Sorin Silaghi

        Activity

        Hide
        Martin Marinschek added a comment -

        Hi Sorin,

        this is not enough, sorry. You'll need to go down the component tree and compare ids one by one to find to the correct component. There can be 10 components with the same id on a page in JSF - as an ID is only unique per naming container.

        Additionally, I asked you to print the last exception in the stacktrace on top additionally to the first exception - so first, the message of the top exception, second the message of the bottom exception, then the full stacktrace.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hi Sorin, this is not enough, sorry. You'll need to go down the component tree and compare ids one by one to find to the correct component. There can be 10 components with the same id on a page in JSF - as an ID is only unique per naming container. Additionally, I asked you to print the last exception in the stacktrace on top additionally to the first exception - so first, the message of the top exception, second the message of the bottom exception, then the full stacktrace. regards, Martin
        Hide
        Sorin Silaghi added a comment -

        new and improved

        Show
        Sorin Silaghi added a comment - new and improved
        Hide
        Sorin Silaghi added a comment -

        this is how the result looks

        Show
        Sorin Silaghi added a comment - this is how the result looks
        Hide
        Martin Marinschek added a comment -

        Hi Sorin,

        very good - I like both the algorithm you used, and the outcome. Nice work!

        Only thing - I can't apply the patch, as the file does seem to be out of date. Can you please recreate the patches?

        Thanks,

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hi Sorin, very good - I like both the algorithm you used, and the outcome. Nice work! Only thing - I can't apply the patch, as the file does seem to be out of date. Can you please recreate the patches? Thanks, regards, Martin
        Hide
        Martin Marinschek added a comment -

        Thanks Sorin, excellent addition to MyFaces.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Thanks Sorin, excellent addition to MyFaces. regards, Martin

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Sorin Silaghi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development