[MYFACES-154] checkbox and listbox do not handler converters well

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.9m9
• Fix Version/s: 1.1.2
• Component/s: General
• Assignee: Bruno Aranda
• Reporter: Han Lee
• Created: 31/Mar/05 05:18
• Updated: 17/Apr/06 20:58
• Resolved: 03/Dec/05 10:10

Description

lookupSet is filled using either getSubmittedValuesAsSet or getSelectedValuesAsSet. Both of these routines use RenderUtils.internalSubmittedOrSelectedValuesAsSet(), which uses RenderUtils.getConvertedStringValue().
getConvertedStringValue() always returns strings. Hence, lookupSet.contains() should always compare against itemStrValue (rather than itemValue.)

This impacts 2 files:

HtmlCheckboxRendererBase.java:
168,170c168,173
< boolean checked = (useSubmittedValues && lookupSet^M
< .contains(itemStrValue))^M
< || (!useSubmittedValues && lookupSet.contains(itemValue));^M
—
> // boolean checked = (useSubmittedValues && lookupSet^M
> // .contains(itemStrValue))^M
> // || (!useSubmittedValues && lookupSet.contains(itemValue));^M
> // HAN - the myfaces code does not work with a converter. The lookupSet=getS*ValuesAsSet() ultimately calls RenderUtils.internalSubmittedOrSelectedValuesAsSet^M
> // That routine calls getConvertedStringValue(); which always returns strings. Hence lookupSet should always be compared to itemStrValue.^M
> boolean checked = lookupSet.contains(itemStrValue);^M

HtmlRendererUtils.java:
457,458c460,464
< if ((useSubmittedValue && lookupSet.contains(itemStrValue))^M
< || (!useSubmittedValue && lookupSet.contains(itemValue))) {^M
—
> // if ((useSubmittedValue && lookupSet.contains(itemStrValue))^M
> // || (!useSubmittedValue && lookupSet.contains(itemValue))) {^M
> // HAN - the myfaces code does not work with a converter. The lookupSet=getS*ValuesAsSet() ultimately calls RenderUtils.internalSubmittedOrSelectedValuesAsSet^M
> // That routine calls getConvertedStringValue(); which always returns strings. Hence lookupSet should always be compared to itemStrValue.^M
> if (lookupSet.contains(itemStrValue)) {^M

Issue Links

• is duplicated by: MYFACES-669 Validation error
• is duplicated by: MYFACES-852 Exception while using SelectManyListbox, SelectManyCheckbox or SelectOneRadio with a Converter.