Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-1523

An HTTP GET with parameters is mistakenly handled like a postback request

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.1.4, 1.1.4.1-SNAPSHOT, 1.1.5-SNAPSHOT
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None

      Description

      This problem, which is also addressed by jsf-1.2 specs, actually afflicts all the pre-1.2.0 myfaces-core versions.

      In these versions, when an HTTP request is issued to myfaces, the package evincts it is a postback request in case at least one POST/GET parameter is issued.

      This can't be always the case, since there is the possibilty that some parameters are somehow used outside of the myfaces framework, expecially in the GET case.

      I propose a solution which basicly assumes that an HTTP request is a postback iff it finds a parameter having a name ending in the _SUBMIT suffix, which is the one adopted by org.apache.myfaces.shared_impl.renderkit.html.HtmlFormRendererBase to mark a form submit.

        Activity

        Hide
        tandraschko Thomas Andraschko added a comment -

        Please check our issue closing policy: http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-project-management.html
        If the is issue is still important for you, please reopen and attach a patch.

        Show
        tandraschko Thomas Andraschko added a comment - Please check our issue closing policy: http://myfaces.apache.org/wiki/core/committer-and-pmc-guide/myfaces-project-management.html If the is issue is still important for you, please reopen and attach a patch.
        Hide
        g.tomassoni Giampaolo Tomassoni added a comment -

        Is there any plan in committing this patch?

        Is there any reason to not commit it?

        Show
        g.tomassoni Giampaolo Tomassoni added a comment - Is there any plan in committing this patch? Is there any reason to not commit it?
        Hide
        manolito Manfred Geiler added a comment -

        deferred until 1.1.6

        Show
        manolito Manfred Geiler added a comment - deferred until 1.1.6

          People

          • Assignee:
            Unassigned
            Reporter:
            g.tomassoni Giampaolo Tomassoni
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development