Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-101 Inefficient portlet dependency fix
  3. MYFACES-1429

Remove rest of the portlet API references from the portlet util.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • 1.1.4
    • 1.1.4
    • Portlet_Support
    • None

    Description

      The source code of the portlet still presents import statements from the portlet API and references portlet API inside in the method:

      /**

      • Determine if we are processing a portlet RenderResponse.
        *
      • @param facesContext The current FacesContext.
      • @return <code>true</code> if we are processing a RenderResponse,
      • <code>false</code> otherwise.
        */
        public static boolean isRenderResponse(FacesContext facesContext) { if (!isPortletRequest(facesContext)) return false; return facesContext.getExternalContext().getResponse() instanceof RenderResponse; }

      the method gets infoked from the org.apache.myfaces.application.jsp.JspViewHandlerImpl line 150 in the call: getActionURL. This call is referenced in the multiple places in jsf core distribution.

      The clean way to resolve portlet api issue whould be to eliminate (compile and runtime) dependency on any of the portlet api classes.

      Attachments

        Activity

          People

            Unassigned Unassigned
            fernir Polina Alber
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: