MyFaces Core
  1. MyFaces Core
  2. MYFACES-1419

javax.faces.convert - refactor common behaviour + DateTimeConverter changes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.4
    • Fix Version/s: 1.1.5
    • Component/s: JSR-127
    • Labels:
      None

      Description

      All available converters look very similar. Extract the common behavior in base class.

      Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
      There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.

      1. converter.patch
        47 kB
        Nikolay Petrov

        Activity

        Nikolay Petrov created issue -
        Nikolay Petrov made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Nikolay Petrov made changes -
        Attachment converter.patch [ 12341292 ]
        Martin Marinschek made changes -
        Assignee Martin Marinschek [ mmarinschek ]
        Martin Marinschek made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Thomas Spiegl made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Thomas Spiegl made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Manfred Geiler made changes -
        Fix Version/s 1.1.5 [ 12312310 ]
        Fix Version/s 1.1.5-SNAPSHOT [ 12311960 ]

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Nikolay Petrov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development