Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-1419

javax.faces.convert - refactor common behaviour + DateTimeConverter changes

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.4
    • Fix Version/s: 1.1.5
    • Component/s: JSR-127
    • Labels:
      None

      Description

      All available converters look very similar. Extract the common behavior in base class.

      Also DateTimeConverter can be migrated to work with type safe enums for style and type properties.
      There are comments in source like //TODO: validate timeStyle. According to java doc of DateTimeConverter on sun there should not have validation. The validation of these will be performed when asString/asObject methods are called.

      1. converter.patch
        47 kB
        Nikolay Petrov

        Activity

        Hide
        tomsp Thomas Spiegl added a comment -

        reverted this patch due to JSF 1.1. incompatibility

        Show
        tomsp Thomas Spiegl added a comment - reverted this patch due to JSF 1.1. incompatibility
        Hide
        tomsp Thomas Spiegl added a comment -

        This patch needs to be reverted. Relevant converters are API classes and must extend from Object.

        Show
        tomsp Thomas Spiegl added a comment - This patch needs to be reverted. Relevant converters are API classes and must extend from Object.
        Hide
        mmarinschek Martin Marinschek added a comment -

        Thanks to Nikolay Petrov for supplying this patch.

        Same reasoning applies here as with Validators, eventually we should prefix the base-class.

        regards,

        Martin

        Show
        mmarinschek Martin Marinschek added a comment - Thanks to Nikolay Petrov for supplying this patch. Same reasoning applies here as with Validators, eventually we should prefix the base-class. regards, Martin

          People

          • Assignee:
            mmarinschek Martin Marinschek
            Reporter:
            ingon Nikolay Petrov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development