Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-1412

Restore view phase does not conforms specification

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1.4
    • 1.1.5
    • JSR-127
    • None

    Description

      JSF 1.1 spec, section 2.2.1 says:
      -Examine the FacesContext instance for the current request. If it already
      contains a UIViewRoot:
      --Set the locale on this UIViewRoot to the value returned by the
      getRequestLocale() method on the ExternalContext for this request.
      --For each component in the component tree, determine if a ValueBinding for
      "binding" is present. If so, call the setValue() method on this
      ValueBinding, passing the component instance on which it was found.
      --Take no further action during this phase.

      As I was looking at restore view phase implementation there was no such behaviour implemented. This should be implemented as:
      if(facesContext.getViewRoot() != null)

      { facesContext.getViewRoot().setLocale(facesContext.getExternalContext().getRequestLocale()); RestoreStateUtils.recursivelyHandleComponentReferencesAndSetValid(facesContext, facesContext.getViewRoot()); return false; }

      At least if understand the code properly.

      Attachments

        1. RestoreViewExecutor.java
          4 kB
          Nikolay Petrov

        Activity

          People

            mmarinschek Martin Marinschek
            ingon Nikolay Petrov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: