MyFaces Core
  1. MyFaces Core
  2. MYFACES-1406

Core and Shared project has dependency on myfaces:myfaces-api version 1.1.1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.5-SNAPSHOT
    • Fix Version/s: 1.1.5
    • Component/s: build process
    • Labels:
      None

      Description

      Core and Shared project has dependency on myfaces:myfaces-api version 1.1.1. Their are 2 problems here:

      1) The dependency group is myfaces instead of org.apache.myfaces.core

      2) The version number is wrong.

      In many places this problem is minimized by the fact that the depenency is marked as "provided". I notices the problem why using eclipse. Eclipse was trying to use the 1.1.1 version of the API even though I was working with the 1.1.5-SNAPSHOT .

      1. patch-to-core.txt
        0.6 kB
        Paul Spencer
      2. patch-to-shared.txt
        0.6 kB
        Paul Spencer

        Activity

        Hide
        Paul Spencer added a comment -

        1) The patch to core uses the current version number in the dependency.

        2) The patch to shared HARDCODE the version number. This MUST be changed during the release process!

        Show
        Paul Spencer added a comment - 1) The patch to core uses the current version number in the dependency. 2) The patch to shared HARDCODE the version number. This MUST be changed during the release process!
        Hide
        Wendy Smoak added a comment -

        Core has a dependency on Shared.

        myfaces/core/impl/pom.xml:
        <artifactItem>
        <groupId>org.apache.myfaces.shared</groupId>
        <artifactId>myfaces-shared-impl</artifactId>
        <version>2.0.4-SNAPSHOT</version>
        </artifactItem>

        Therefore, Shared cannot depend on the current snapshot of Core or we will have a circular dependency. (Note that it's in a plugin execution and not a normal <dependency>, so Maven won't catch it during dependency resolution.)

        The JSF 1.1 API hasn't changed, so it shouldn't matter whether myfaces-impl builds against 1.1.1 or 1.1.5-SNAPSHOT (or against the API jar from the reference implementation, for that matter.) I'm not as opposed to this one, but I don't think it's necessary... and the fewer snapshot dependencies the better. The situation may improve once 1.1.4 is available, because it will be in the same groupId as the current snapshot.

        Show
        Wendy Smoak added a comment - Core has a dependency on Shared. myfaces/core/impl/pom.xml: <artifactItem> <groupId>org.apache.myfaces.shared</groupId> <artifactId>myfaces-shared-impl</artifactId> <version>2.0.4-SNAPSHOT</version> </artifactItem> Therefore, Shared cannot depend on the current snapshot of Core or we will have a circular dependency. (Note that it's in a plugin execution and not a normal <dependency>, so Maven won't catch it during dependency resolution.) The JSF 1.1 API hasn't changed, so it shouldn't matter whether myfaces-impl builds against 1.1.1 or 1.1.5-SNAPSHOT (or against the API jar from the reference implementation, for that matter.) I'm not as opposed to this one, but I don't think it's necessary... and the fewer snapshot dependencies the better. The situation may improve once 1.1.4 is available, because it will be in the same groupId as the current snapshot.
        Show
        Wendy Smoak added a comment - Related thread: http://www.nabble.com/Shared-and-API-circular-dependency%2C-related-to-%28MYFACES-1406%29-p6239070.html
        Hide
        Martin Marinschek added a comment -

        Hmm...

        we'd need a dependency from core-impl to shared and from both core-impl and shared to core-api. Is this not possible?

        regards,

        Martin

        Show
        Martin Marinschek added a comment - Hmm... we'd need a dependency from core-impl to shared and from both core-impl and shared to core-api. Is this not possible? regards, Martin
        Hide
        Wendy Smoak added a comment -

        This one is on my list to look at now that 1.1.4 is available in the central Maven repo.

        My theory is that since both 1.1.4 and 1.1.5-SNAPSHOT have the same groupId, Maven will figure out that they are two versions of the same library, and pick the later version.

        Show
        Wendy Smoak added a comment - This one is on my list to look at now that 1.1.4 is available in the central Maven repo. My theory is that since both 1.1.4 and 1.1.5-SNAPSHOT have the same groupId, Maven will figure out that they are two versions of the same library, and pick the later version.
        Hide
        Wendy Smoak added a comment -
        Show
        Wendy Smoak added a comment - Updated dependencies to 1.1.4 which has the same groupId as the current snapshot. http://svn.apache.org/viewvc?view=rev&rev=473177 http://svn.apache.org/viewvc?view=rev&rev=473179 http://svn.apache.org/viewvc?view=rev&rev=473180

          People

          • Assignee:
            Wendy Smoak
            Reporter:
            Paul Spencer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development