Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1.5-SNAPSHOT
    • Fix Version/s: 1.1.5
    • Component/s: General
    • Labels:
      None

      Description

      The current version of 1.1.5-SNAPSHOT had state saving code built into the view-handler. Facelets replaces the view-handler; so this was an attempt that didn't work.

      Resolution:

      • moving all the state saving code (especially: view-sequence-id) into the state-manager
      • letting the HtmlResponseStateManager write code not only in the client-side state saving case, but also in the server-side state saving case

      how to see that it still doesn't work: watch for issues with the back-button. If you click on the back-button, does a click on a link move you to the next page? If the first one doesn't, but the second one does, this problem has reoccurred and we need to reopen this bug.

      Can anyone check that this really works with Facelets?

      regards,

      Martin

        Activity

        Hide
        Thomas Spiegl added a comment -

        Removed rendering of hidden input jsf_sequence. In ServerSide state saving mode, the view sequence will be saved via treeStructure.
        See JspStateManagerImpl.saveSerializedView(...)

        Any ResponseStateManager will save the tree state. So the view sequence for the preceding request can be extracted from the tree state.

        this will be rendered instead of hidden input "jsf_sequence" when using the MyFaces Renderkit:

        <input type="hidden" value="1" id="jsf_tree" name="jsf_tree" >

        Show
        Thomas Spiegl added a comment - Removed rendering of hidden input jsf_sequence. In ServerSide state saving mode, the view sequence will be saved via treeStructure. See JspStateManagerImpl.saveSerializedView(...) Any ResponseStateManager will save the tree state. So the view sequence for the preceding request can be extracted from the tree state. this will be rendered instead of hidden input "jsf_sequence" when using the MyFaces Renderkit: <input type="hidden" value="1" id="jsf_tree" name="jsf_tree" >
        Hide
        Thomas Spiegl added a comment -

        jsf_sequence may not be rendered by HtmlResponseStateManger cause this breaks Trinidad. Trinidad and other component libraries may have there own ResponseStateManager implementation. There is no guarantee that MyFaces HtmlResponseStateManger is called.

        Show
        Thomas Spiegl added a comment - jsf_sequence may not be rendered by HtmlResponseStateManger cause this breaks Trinidad. Trinidad and other component libraries may have there own ResponseStateManager implementation. There is no guarantee that MyFaces HtmlResponseStateManger is called.

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Martin Marinschek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development