[MYFACES-1386] PropertyResolverImpl.setProperty lacks usefull error mesage if write method not found

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.5-SNAPSHOT
• Fix Version/s: 1.1.5
• Assignee: Unassigned
• Reporter: Ronald Brill
• Created: 16/Aug/06 07:49
• Updated: 14/Feb/07 00:25
• Resolved: 17/Aug/06 05:05

Description

my managed bean was lacking a setter for a property. Due to a non-descriptive error message I was unable to identify the source of the problem. After debugging, this code block was identified that lacks a descriptive error message.

Error message was:
Bean: com.somedomain.Controller, property: alertDiffResult Bean: com.somedomain.Controller, property: alertDiffResult

Error message should be:
Bean: com.somedomain.Controller, property: alertDiffResult Bean: com.somedomain.Controller, property: alertDiffResult (no write method for property)

suggested patch:

public static void setProperty(Object base, String name, Object newValue)
{
PropertyDescriptor propertyDescriptor =
getPropertyDescriptor(base, name);

Method m = propertyDescriptor.getWriteMethod();
if (m == null)

{ throw new PropertyNotFoundException( getMessage(base, name)+ " (no write method for property!)"); }

...