MyFaces Core
  1. MyFaces Core
  2. MYFACES-1360

HtmlMessagesRendererBase - change two method modifiers to protected

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.3
    • Fix Version/s: 1.1.5
    • Component/s: None
    • Labels:
      None

      Description

      I would like to extend the HtmlMessagesRendererBase and overwrite the methods renderList and renderTable in order to add styleClasses to the generated list elements. Unfortunately these methods (and the internal class MessagesIterator) are private.
      Is there any reason why these methods are not protected?

        Activity

        Michael Heinen created issue -
        Michael Heinen made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Michael Heinen added a comment -

        two methods modifiers and MessagesIterator changed from private to protected.

        Show
        Michael Heinen added a comment - two methods modifiers and MessagesIterator changed from private to protected.
        Michael Heinen made changes -
        Attachment HtmlMessagesRendererBase.patch [ 12336593 ]
        Hide
        Martin Marinschek added a comment -

        You can certainly extend, but in any case there might be the possibility that signatures change in renderers.

        regards,

        Martin

        Show
        Martin Marinschek added a comment - You can certainly extend, but in any case there might be the possibility that signatures change in renderers. regards, Martin
        Martin Marinschek made changes -
        Fix Version/s 1.1.5-SNAPSHOT [ 12311960 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Martin Marinschek [ mmarinschek ]
        Manfred Geiler made changes -
        Fix Version/s 1.1.5 [ 12312310 ]
        Fix Version/s 1.1.5-SNAPSHOT [ 12311960 ]
        Manfred Geiler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Martin Marinschek
            Reporter:
            Michael Heinen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development