[MYFACES-1328] UISelectOne and UISelectMany fail with custom converter that returns java.lang.String from getAsObject() method.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.4-SNAPSHOT
• Fix Version/s: 1.1.5
• Assignee: Martin Marinschek
• Reporter: Alexey Maslov
• Created: 08/Jun/06 00:10
• Updated: 26/Apr/07 21:39
• Resolved: 05/Oct/06 22:06

Description

The problem seems to be in javax.faces.component._SelectItemsUtil.matchValue(FacesContext context, Object value, Iterator selectItemsIter, _ValueConverter converter) method.

Line 63-72:
Object itemValue = item.getValue();
if(converter != null && itemValue instanceof String)

{ itemValue = converter.getConvertedValue(context, (String)itemValue); }

if (value==itemValue || value.equals(itemValue))

{ return true; }

If item's value is java.lang.String then this code does duplicate conversion making matchValue() return false and subsequently resulting in error in calling method (validateValue() in javax.faces.component.UISelectOne and javax.faces.component.UISelectMany).