[MWRAPPER-112] Detection of JAVA_HOME fails due to bad quoting

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.2.0, 3.3.0
• Fix Version/s: 3.3.0
• Labels: pull-request-available
• Environment: Ubuntu 20.04, Java 17
• Flags: Patch
• Assignee: Benjamin Marwell
• Reporter: Ingo Karkat
• Created: 13/Jun/23 07:28
• Updated: 17/Apr/24 09:12
• Resolved: 05/Feb/24 18:48

Description

I have a standard Ubuntu 20.04 Java installation (openjdk-17-jdk APT package, /usr/bin/javac linked to /usr/lib/jvm/java-17-openjdk-amd64/bin/javac via the update-alternatives system, no JAVA_HOME set). Maven Wrapper 3.2.0 should detect that, but on each invocation prints this warning:

Warning: JAVA_HOME environment variable is not set.

This is caused by excessive quoting (i.e. the \"):

javaExecutable="$(readlink -f "\"$javaExecutable\"")"

Apparently, that code has been in the codebase since the beginning, taken over from the gradlew wrapper (which had the shell wrappers completely rewritten; there are no remnants of this code found there any longer).

Pull request: https://github.com/apache/maven-wrapper/pull/102

Issue Links

• links to: GitHub Pull Request #102