Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-alpha-2
    • Fix Version/s: 2.1-beta-1
    • Component/s: None
    • Labels:
      None
    • Environment:
      RHEL 3

      Description

      The <warSourceIncludes> element no longer seems to work, as of 2.1-alpha-2. It does seem to work in 2.1-alpha-1. I am attaching a pom.xml file which will demonstrate the problem when used as follows:

      1) From the directory containing the pom.xml, create a web.xml, because otherwise it fails (setting failsOnMissingWebXml didn't seem to do the trick):
      mkdir -p src/main/webapp/WEB-INF
      touch src/main/webapp/WEB-INF/web.xml

      2) Build with the 2.1-alpha-1 plugin
      mvn clean install -Dwar.plugin.version=2.1-alpha-1

      3) Dump out the jar contents to verify that only commons-logging and the web.xml were packaged, as requested
      [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
      META-INF/
      META-INF/MANIFEST.MF
      WEB-INF/
      WEB-INF/web.xml
      WEB-INF/lib/
      WEB-INF/lib/commons-logging-1.1.jar
      META-INF/maven/
      META-INF/maven/example/
      META-INF/maven/example/example-war/
      META-INF/maven/example/example-war/pom.xml
      META-INF/maven/example/example-war/pom.properties

      4) Now build using the 2.1-alpha-2 plugin version:
      mvn clean install -Dwar.plugin.version=2.1-alpha-2

      5) Dump out the jar contents and notice that warSourceIncludes was ignored this time:
      [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
      META-INF/
      META-INF/MANIFEST.MF
      WEB-INF/
      WEB-INF/classes/
      WEB-INF/lib/
      WEB-INF/web.xml
      WEB-INF/lib/commons-logging-1.1.jar
      WEB-INF/lib/log4j-1.2.12.jar
      WEB-INF/lib/logkit-1.0.1.jar
      WEB-INF/lib/avalon-framework-4.1.3.jar
      WEB-INF/lib/servlet-api-2.3.jar
      META-INF/maven/
      META-INF/maven/example/
      META-INF/maven/example/example-war/
      META-INF/maven/example/example-war/pom.xml
      META-INF/maven/example/example-war/pom.properties

      1. pom.xml
        1 kB
        Bryan Loofbourrow

        Issue Links

          Activity

          Bryan Loofbourrow created issue -
          Dennis Lundberg made changes -
          Field Original Value New Value
          Summary warSourceIncludes no longer works warSourceExcludes no longer works
          Description The <warSourceExcludes> element no longer seems to work, as of 2.1-alpha-2. It does seem to work in 2.1-alpha-1. I am attaching a pom.xml file which will demonstrate the problem when used as follows:

          1) From the directory containing the pom.xml, create a web.xml, because otherwise it fails (setting failsOnMissingWebXml didn't seem to do the trick):
                mkdir -p src/main/webapp/WEB-INF
                touch src/main/webapp/WEB-INF/web.xml

          2) Build with the 2.1-alpha-1 plugin
               mvn clean install -Dwar.plugin.version=2.1-alpha-1

          3) Dump out the jar contents to verify that only commons-logging and the web.xml were packaged, as requested
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/web.xml
          WEB-INF/lib/
          WEB-INF/lib/commons-logging-1.1.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          4) Now build using the 2.1-alpha-2 plugin version:
               mvn clean install -Dwar.plugin.version=2.1-alpha-1

          5) Dump out the jar contents and notice that warSourceIncludes was ignored this time:
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/classes/
          WEB-INF/lib/
          WEB-INF/web.xml
          WEB-INF/lib/commons-logging-1.1.jar
          WEB-INF/lib/log4j-1.2.12.jar
          WEB-INF/lib/logkit-1.0.1.jar
          WEB-INF/lib/avalon-framework-4.1.3.jar
          WEB-INF/lib/servlet-api-2.3.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          The <warSourceExcludes> element no longer seems to work, as of 2.1-alpha-2. It does seem to work in 2.1-alpha-1. I am attaching a pom.xml file which will demonstrate the problem when used as follows:

          1) From the directory containing the pom.xml, create a web.xml, because otherwise it fails (setting failsOnMissingWebXml didn't seem to do the trick):
                mkdir -p src/main/webapp/WEB-INF
                touch src/main/webapp/WEB-INF/web.xml

          2) Build with the 2.1-alpha-1 plugin
               mvn clean install -Dwar.plugin.version=2.1-alpha-1

          3) Dump out the jar contents to verify that only commons-logging and the web.xml were packaged, as requested
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/web.xml
          WEB-INF/lib/
          WEB-INF/lib/commons-logging-1.1.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          4) Now build using the 2.1-alpha-2 plugin version:
               mvn clean install -Dwar.plugin.version=2.1-alpha-2

          5) Dump out the jar contents and notice that warSourceIncludes was ignored this time:
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/classes/
          WEB-INF/lib/
          WEB-INF/web.xml
          WEB-INF/lib/commons-logging-1.1.jar
          WEB-INF/lib/log4j-1.2.12.jar
          WEB-INF/lib/logkit-1.0.1.jar
          WEB-INF/lib/avalon-framework-4.1.3.jar
          WEB-INF/lib/servlet-api-2.3.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          Dennis Lundberg made changes -
          Link This issue is duplicated by MWAR-181 [ MWAR-181 ]
          Dennis Lundberg made changes -
          Summary warSourceExcludes no longer works warSourceIncludes no longer works
          Description The <warSourceExcludes> element no longer seems to work, as of 2.1-alpha-2. It does seem to work in 2.1-alpha-1. I am attaching a pom.xml file which will demonstrate the problem when used as follows:

          1) From the directory containing the pom.xml, create a web.xml, because otherwise it fails (setting failsOnMissingWebXml didn't seem to do the trick):
                mkdir -p src/main/webapp/WEB-INF
                touch src/main/webapp/WEB-INF/web.xml

          2) Build with the 2.1-alpha-1 plugin
               mvn clean install -Dwar.plugin.version=2.1-alpha-1

          3) Dump out the jar contents to verify that only commons-logging and the web.xml were packaged, as requested
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/web.xml
          WEB-INF/lib/
          WEB-INF/lib/commons-logging-1.1.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          4) Now build using the 2.1-alpha-2 plugin version:
               mvn clean install -Dwar.plugin.version=2.1-alpha-2

          5) Dump out the jar contents and notice that warSourceIncludes was ignored this time:
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/classes/
          WEB-INF/lib/
          WEB-INF/web.xml
          WEB-INF/lib/commons-logging-1.1.jar
          WEB-INF/lib/log4j-1.2.12.jar
          WEB-INF/lib/logkit-1.0.1.jar
          WEB-INF/lib/avalon-framework-4.1.3.jar
          WEB-INF/lib/servlet-api-2.3.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          The <warSourceIncludes> element no longer seems to work, as of 2.1-alpha-2. It does seem to work in 2.1-alpha-1. I am attaching a pom.xml file which will demonstrate the problem when used as follows:

          1) From the directory containing the pom.xml, create a web.xml, because otherwise it fails (setting failsOnMissingWebXml didn't seem to do the trick):
                mkdir -p src/main/webapp/WEB-INF
                touch src/main/webapp/WEB-INF/web.xml

          2) Build with the 2.1-alpha-1 plugin
               mvn clean install -Dwar.plugin.version=2.1-alpha-1

          3) Dump out the jar contents to verify that only commons-logging and the web.xml were packaged, as requested
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/web.xml
          WEB-INF/lib/
          WEB-INF/lib/commons-logging-1.1.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          4) Now build using the 2.1-alpha-2 plugin version:
               mvn clean install -Dwar.plugin.version=2.1-alpha-2

          5) Dump out the jar contents and notice that warSourceIncludes was ignored this time:
              [warsourceexample]$ jar -tf target/example-war-0.1-SNAPSHOT.war
          META-INF/
          META-INF/MANIFEST.MF
          WEB-INF/
          WEB-INF/classes/
          WEB-INF/lib/
          WEB-INF/web.xml
          WEB-INF/lib/commons-logging-1.1.jar
          WEB-INF/lib/log4j-1.2.12.jar
          WEB-INF/lib/logkit-1.0.1.jar
          WEB-INF/lib/avalon-framework-4.1.3.jar
          WEB-INF/lib/servlet-api-2.3.jar
          META-INF/maven/
          META-INF/maven/example/
          META-INF/maven/example/example-war/
          META-INF/maven/example/example-war/pom.xml
          META-INF/maven/example/example-war/pom.properties

          Dennis Lundberg made changes -
          Link This issue is duplicated by MWAR-181 [ MWAR-181 ]
          Dennis Lundberg made changes -
          Fix Version/s 2.1-beta-1 [ 12616 ]
          Assignee Dennis Lundberg [ dennislundberg ]
          Dennis Lundberg made changes -
          Link This issue is related to MWAR-81 [ MWAR-81 ]
          Dennis Lundberg made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 13:28:45 UTC 2015 [ 1428240525159 ]
          Mark Thomas made changes -
          Workflow jira [ 12728596 ] Default workflow, editable Closed status [ 12765032 ]
          Mark Thomas made changes -
          Project Import Mon Apr 06 01:49:55 UTC 2015 [ 1428284995525 ]
          Mark Thomas made changes -
          Workflow jira [ 12966492 ] Default workflow, editable Closed status [ 13002933 ]
          Mark Thomas made changes -
          Assignee dennislundberg [ dennislundberg ] Dennis Lundberg [ dennisl@apache.org ]

            People

            • Assignee:
              Dennis Lundberg
              Reporter:
              Bryan Loofbourrow
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development