Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 2.0-beta-1
    • Component/s: None
    • Labels:
      None

      Description

      Because of MTOMCAT-62 I think it is necessary to have automatic integration tests to see if the migration to Tomcat 7 works without problems. To achieve this I have a proposal for integration tests. In addition I also restructured the whole tomcat-maven-plugin. The main artifact is now tomcat6x-maven-plugin as I think we will need tomcat7x-maven-plugin as extra module and perhaps tomcat-maven-plugin-common for shared artifacts.

      The first integration test added is the one you already provided in the sources. But now it is automatically executed.

      To test the whole plugin call the parent POM with:

      tomcat-maven-plugin/# mvn clean verify -P integration-test
      

      This will ensure that the plugin is installed in the phase pre-integration-test rather than install and that the Integration Test module is actually added.

      Because of the Major change I suggest to move to version number 2.0-SNAPSHOT so that version 2.0 will come with Tomcat 7 support eventually.

        Activity

        Mark Michaelis created issue -
        Hide
        Mark Thomas added a comment -

        Attached [^svn-diff.patch] – sorry, thought that Idea automatically added the moved files. Hope the patch works for you. Otherwise please tell me.

        Btw: I applied for a membership in the Mojo project – so if I get accepted I could perhaps support you directly.

        Show
        Mark Thomas added a comment - Attached [^svn-diff.patch] – sorry, thought that Idea automatically added the moved files. Hope the patch works for you. Otherwise please tell me. Btw: I applied for a membership in the Mojo project – so if I get accepted I could perhaps support you directly.
        Hide
        Mark Thomas added a comment -

        First integration tests added as proof-of-concept. Further integration tests might be added now.

        Show
        Mark Thomas added a comment - First integration tests added as proof-of-concept. Further integration tests might be added now.
        Hide
        Mark Thomas added a comment -

        Hi,
        I have try to apply the patch.
        It looks weird because it contains only deleted content did you miss some svn add before your svn diff ?

        Show
        Mark Thomas added a comment - Hi, I have try to apply the patch. It looks weird because it contains only deleted content did you miss some svn add before your svn diff ?
        Mark Thomas made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Olivier Lamy (*$^¨%`£) made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Mark Michaelis [ thragor ] Olivier Lamy [ olamy ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        336d 15h 41m 1 Mark Thomas 07/Sep/11 22:18
        Resolved Resolved Closed Closed
        119d 18h 37m 1 Olivier Lamy (*$^¨%`£) 05/Jan/12 15:55

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Mark Michaelis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development