Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: None
    • Labels:
      None

      Description

      Apply the change of MTOMCAT-23 to all other isWar checks - especially to org.codehaus.mojo.tomcat.AbstractWarCatalinaMojo which should be equal to org.codehaus.mojo.tomcat.AbstractRunMojo.

      Background: We use the maven-tomcat-plugin for integration tests and the WAR comes from another module. So while we can use tomcat:run-war to start the Tomcat with the Webapp (we unpacked it before) we have no chance to stop the tomcat after the integration tests are done.

        Activity

        Mark Michaelis created issue -
        Hide
        Mark Thomas added a comment -

        Attached [^MTOMCAT-63.patch] which contains the required changes. Not a great job though. Just copy and paste from the existing solution.

        Show
        Mark Thomas added a comment - Attached [^MTOMCAT-63.patch] which contains the required changes. Not a great job though. Just copy and paste from the existing solution.
        Hide
        Mark Thomas added a comment -

        Actually my real problem was described in MTOMCAT-55. This issue is not really required but it makes sense to resolve it to make the isWar check consistent.

        Show
        Mark Thomas added a comment - Actually my real problem was described in MTOMCAT-55 . This issue is not really required but it makes sense to resolve it to make the isWar check consistent.
        Hide
        Mark Thomas added a comment -

        fixed rev 12741
        Thanks !

        Show
        Mark Thomas added a comment - fixed rev 12741 Thanks !
        Mark Thomas made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        343d 9h 17m 1 Mark Thomas 07/Sep/11 22:18

          People

          • Assignee:
            Olivier Lamy (*$^¨%`£)
            Reporter:
            Mark Michaelis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development