Hi,
In which version do you think to treat this issue or how do you plan to solve it (a new branch?)?
The solution would largely help to test and integrate a new jsr-356 websocket implementation.
Marek

The problem is in changed Tomcat 8 API, the maven throws folloving exception:
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
... 20 more
by: java.lang.NoSuchMethodError: org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
... 20 more

The method setDefaultRealm is deprecated in Tomcat7 and was removed in Tomcat8 as described in documentation:

The method setDefaultRealm was deprecated in r1230777 as part of the changes to fix bug 52443
http://svn.apache.org/viewvc?view=revision&revision=1230777
https://issues.apache.org/bugzilla/show_bug.cgi?id=52443

The alternative to {{embeddedTomcat.setDefaultRealm( memoryRealm ) }} call that should work with both Tomcat 7 and 8 is {{embeddedTomcat.getEngine().setRealm( memoryRealm ) }}.

(It is a bit of a waste that Tomcat.getEngine() creates a default realm implementation that will be immediately replaced here. It would be possible in avoid creating that object by reintroducing the "setDefaultRealm()" method in Tomcat 8).

Any news on this one? It's blocking me for more than 6 months now and I can't update to servlet specification 3.1

Do you think there's any chance of progress on this issue now that Tomcat 8 is considered stable (8.0.9)? Thanks.

Hi,
I started a branch here https://svn.apache.org/repos/asf/tomcat/maven-plugin/branches/tc8.x/
This is also available in github if you want to participate with pull requests ( https://github.com/apache/tomcat-maven-plugin )
ATM I don't have a lot of time for that
Any help will be appreciate!!

Hi,

What else exactly is left to do there?

I got the code from GitHub and ran the build with run-its profile. I see ITs are failing. And now what?.. If I manage to get all them passing, will that be considered as ready-to-release plugin? Just at a shallow glance there is not a lot of work there, and as it is a kind of a blocker for me as well, much like as for Petar, I'm eager to spend time fixing it. However, I will hold off doing so if plugin author advices that a complete overhaul is to be done

Thanks.

There are still some Classloader issues to fix with tomcat8:run

About the Classloader issue, it seems that classes are not loaded from inside the jar file but as the jar file itself.

I get an error message like "java.lang.ClassFormatError: Incompatible magic value 1347093252 in class file...", 1347093252 = 0x504B0304 = "PK.." (magic string of a zip file). The normal magic string should be 0xCAFEBABE in java class format.

I could fix it by changing 2 things in the RunMojo (in the code that iterates over the jarPaths):

1. return a JarResource instead of a FileResource
2. remove the condition "ends with .class", otherwise non-classes resources could not be loaded (*.properties)

Do you need a PR?

Xavier Dury if you have time for pr I will like that for sure

GitHub user kalgon opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/7

MTOMCAT-234 Classloading issues

this fixes the `java.lang.ClassFormatError` but there is another problem: it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies instead of the webapp ones. The result is that no `web-fragment.xml` or `ServletContainerInitializer` works anymore (and I suspect there should be other consequences as well). I did not have enough time to investigate but I noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't know the internals of Tomcat very well. I'll try to make some time next week to dig a bit deeper.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7

commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496
Author: kalgon <kalgon@hotmail.com>
Date: 2014-08-14T10:47:12Z

MTOMCAT-234 Classloading issues

Github user kalgon closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/7

GitHub user anenviousguest opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/9

MTOMCAT-234 (Tomcat8 plugin is now working) + MTOMCAT-274

Hi,
Don't know how to split this request into two separate ones. Anyway, I finally got Tomcat 8 plugin passing integration tests.
One thing: it seems that integration tests start embedded Tomcat with http-nio protocol handler, rather than with http-bio, which means that assertion statements had to be changed accordingly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9

commit a2e146c785e7f1c964b5d875c78a0bea034dfc78
Author: Vladislav Ponomarev <ponomarevvlad@gmail.com>
Date: 2014-08-15T08:12:52Z

1. Fix: MTOMCAT-274 (updated maven-war-plugin version).
2. Fix: access_log.* files excluded from apache-rat-plugin configuration. These are generated during Tomcat run and should not be checked.

commit 952e3d3f9e0c7d1fcb86cc1594f74ebb3648092e
Author: Vladislav Ponomarev <ponomarevvlad@gmail.com>
Date: 2014-08-17T13:26:33Z

Fix: MTOMCAT-234

Hi guys,

Would appreciate if you could take a look at my pool request. I eventually got all integration tests passing.

Thanks.

Github user anenviousguest closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/9

When will the tomcat8-maven-plugin be released?

Any indication of when tomcat 8 will be supported?

So guys.
FYI there is a branch available here: http://svn.apache.org/repos/asf/tomcat/maven-plugin/branches/tc8.x/ or in github https://github.com/apache/tomcat-maven-plugin .
Bad but I don't have the bandwith ATM to fix last issues.
So ATM, it works except for jsp compilation.
Logs:

SEVERE: Servlet.service() for servlet [jsp] in context with path [/multi-config] threw exception [java.lang.LinkageError: loader constraint violation: when resolving method "org.apache.jasper.r
untime.InstanceManagerFactory.getInstanceManager(Ljavax/servlet/ServletConfig;)Lorg/apache/tomcat/InstanceManager;" the class loader (instance of org/apache/jasper/servlet/JasperLoader) of the 
current class, org/apache/jsp/index_jsp, and the class loader (instance of org/codehaus/plexus/classworlds/realm/ClassRealm) for resolved class, org/apache/jasper/runtime/InstanceManagerFactory
, have different Class objects for the type .getInstanceManager(Ljavax/servlet/ServletConfig;)Lorg/apache/tomcat/InstanceManager; used in the signature] with root cause
java.lang.LinkageError: loader constraint violation: when resolving method "org.apache.jasper.runtime.InstanceManagerFactory.getInstanceManager(Ljavax/servlet/ServletConfig;)Lorg/apache/tomcat/
InstanceManager;" the class loader (instance of org/apache/jasper/servlet/JasperLoader) of the current class, org/apache/jsp/index_jsp, and the class loader (instance of org/codehaus/plexus/cla
ssworlds/realm/ClassRealm) for resolved class, org/apache/jasper/runtime/InstanceManagerFactory, have different Class objects for the type .getInstanceManager(Ljavax/servlet/ServletConfig;)Lorg
/apache/tomcat/InstanceManager; used in the signature

To reproduce: mvn clean install -Prun-its
Then see the file: tomcat8-maven-plugin/target/test-classes/tomcat-run-multi-config/log.txt

So any help/patches/pull request are accepted and will be appreciated
Cheers

We are about to initiate a project to switch all of our applications from a mixture of Tomcat 6/7 to Tomcat 8 so having this plugin available soon would be really useful.

I'm about to go away on my honeymoon for 3 weeks but I will take a look at this when I get back at the end of October from the 26th.

I'll also take a look at MTOMCAT-274 which looks like it could block this feature but seems to have a closed pull request by the reporter so its not clear to me whether or not it is a real issue.

Then there is also MTOMCAT-294 which I'll review the open pull request for.

If there is anything else that would be useful for me to do in order to get closer towards a 3.0 release, please do let me know.

So married life is much more busy than I had anticipated but I've found a bit of time to look at this.

For starters, I've found another bug that will block this (MTOMCAT-302) and opened a pull request in that ticket to fix it.

MTOMCAT-302 has been resolved... So is this getting any closer?

3 months have elapsed since last comment, and 4 months since MTOMCAT-302 was resolved. Still no update?

Also waiting for this. While it's possible to build the https://github.com/apache/tomcat-maven-plugin/tree/tc8.x branch locally, this doesn't work with tomcat 8.5 which is now the recommended 8.x version (and it's also not just a matter of exchanging the tomcat dependency). It would be great to have the maven plugin available for 8.5.x. If additionally there'd be a released version for tomcat 8.0.x this would be just awesome!

FAILURE: Integrated in Jenkins build TomcatMavenPlugin-mvn3.x-windows #10 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x-windows/10/)
Fix: MTOMCAT-234 (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1756447)

• (edit) tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/AbstractRunMojo.java
• (edit) tomcat8-maven-plugin/src/test/java/org/apache/tomcat/maven/it/Tomcat8RunMultiConfigIT.java
• (edit) tomcat8-maven-plugin/src/test/java/org/apache/tomcat/maven/it/Tomcat8SimpleWarProjectIT.java
  MTOMCAT-234 Classloading issues (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1756445)
• (edit) tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java

FAILURE: Integrated in Jenkins build TomcatMavenPlugin-mvn3.x #294 (See https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/294/)
Fix: MTOMCAT-234 (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1756447)

• (edit) tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/AbstractRunMojo.java
• (edit) tomcat8-maven-plugin/src/test/java/org/apache/tomcat/maven/it/Tomcat8RunMultiConfigIT.java
• (edit) tomcat8-maven-plugin/src/test/java/org/apache/tomcat/maven/it/Tomcat8SimpleWarProjectIT.java
  MTOMCAT-234 Classloading issues (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1756445)
• (edit) tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java