[MSKINS-185] Don't fall back anymore if bannerLeft ist not provided

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: fluido-1.10.0
• Fix Version/s: fluido-1.11.0
• Component/s: Fluido Skin
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 08/May/22 13:20
• Updated: 10/May/22 17:45
• Resolved: 10/May/22 17:03

Description

bannerLeft is always populated if no site.xml is given:
https://github.com/apache/maven-doxia-sitetools/blob/9a34df07c7d2e56f4f3eab3c742e532ab60d79fb/doxia-integration-tools/src/main/resources/default-site.xml#L21-L33
If site.xml is given and not set, it will be autoset:
https://github.com/apache/maven-doxia-sitetools/blob/9a34df07c7d2e56f4f3eab3c742e532ab60d79fb/doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java#L471-L477

So the fallback as no effect because bannerLeft is always present. Also use <h1/> to indicate a top most header.

Issue Links

• links to: GitHub Pull Request #27