Maven Site Plugin
  1. Maven Site Plugin
  2. MSITE-368

remove copy of reporting-api SinkFactory class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta-7
    • Fix Version/s: 2.1
    • Component/s: doxia integration
    • Labels:
      None

      Description

      this will force the plugin to have Maven 2.0.8 as a prerequisite, since this interface was added in doxia-sink-api 1.0-alpha-9, in use in Maven 2.0.8

        Issue Links

          Activity

          Hervé Boutemy created issue -
          Hervé Boutemy made changes -
          Field Original Value New Value
          Affects Version/s 2.0-beta-7 [ 13092 ]
          Component/s doxia integration [ 12130 ]
          Hervé Boutemy made changes -
          Fix Version/s 2.1 [ 14324 ]
          Hervé Boutemy made changes -
          Link This issue is related to MSITE-369 [ MSITE-369 ]
          Hide
          Dennis Lundberg added a comment -

          Is it only the class org.apache.maven.doxia.sink.SinkFactory that should be removed?

          Show
          Dennis Lundberg added a comment - Is it only the class org.apache.maven.doxia.sink.SinkFactory that should be removed?
          Hide
          Hervé Boutemy added a comment -

          I wrote "sorting out Maven dependencies on Doxia" section in Doxia Release Plan to track precisely the logic I found when reading code history.

          then AFAIK, this is the only class that should be removed from maven-site-plugin 2.1. MSITE-369 is here for another class in version 3.0.
          This analysis should probably be reviewed by every Doxia developers since it's not so easy: the more eyes (and brains) the better.

          Show
          Hervé Boutemy added a comment - I wrote "sorting out Maven dependencies on Doxia" section in Doxia Release Plan to track precisely the logic I found when reading code history. then AFAIK, this is the only class that should be removed from maven-site-plugin 2.1. MSITE-369 is here for another class in version 3.0. This analysis should probably be reviewed by every Doxia developers since it's not so easy: the more eyes (and brains) the better.
          Hide
          Lukas Theussl added a comment -

          The only possible problem I see is that the SinkFactory in Doxia 1.1 is not identical anymore to the SinkFactory in Doxia 1.0 (which the site plugin has copied), some signatures where added for 1.1. However, the site plugin now has a prereq on maven 2.1 (using doxia-1.1), so I think at least binary compatibility should be ok. I'd remove the class already and see what happens on the grid...

          Show
          Lukas Theussl added a comment - The only possible problem I see is that the SinkFactory in Doxia 1.1 is not identical anymore to the SinkFactory in Doxia 1.0 (which the site plugin has copied), some signatures where added for 1.1. However, the site plugin now has a prereq on maven 2.1 (using doxia-1.1), so I think at least binary compatibility should be ok. I'd remove the class already and see what happens on the grid...
          Hide
          Lukas Theussl added a comment -

          Done in r890870. Grid seems happy...

          Show
          Lukas Theussl added a comment - Done in r890870 . Grid seems happy...
          Lukas Theussl made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Assignee Lukas Theussl [ lukas ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 13:16:22 UTC 2015 [ 1428239782088 ]
          Mark Thomas made changes -
          Workflow jira [ 12726736 ] Default workflow, editable Closed status [ 12757128 ]
          Mark Thomas made changes -
          Project Import Mon Apr 06 01:19:02 UTC 2015 [ 1428283142430 ]
          Mark Thomas made changes -
          Workflow jira [ 12964452 ] Default workflow, editable Closed status [ 13001455 ]
          Mark Thomas made changes -
          Assignee Lukas JOSEFIK [ lukas ] Lukas Theussl [ ltheussl ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          403d 18h 43m 1 Lukas Theussl 16/Dec/09 04:06

            People

            • Assignee:
              Lukas Theussl
              Reporter:
              Hervé Boutemy
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development