[MSITE-237] Empty modules list generated when using '--non-recursive' flag for single module projects

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Won't Fix
• Affects Version/s: 2.0-beta-5
• Component/s: multi module
• Assignee: Unassigned
• Reporter: Paul Lindner
• Created: 19/Jun/07 08:17
• Updated: 08/Feb/09 16:24
• Resolved: 08/Feb/09 16:24

Description

Using '--non-recursive' flag for a single module project causes site's modules list to be empty.

When starting a new project it's usual to have just one module for a while.

It seems to be a problem in *org.apache.maven.plugins.site.AbstractSiteMojo" class, inside populateModulesMenuItemsFromModels method, when models.size() is checked.

AbstractSiteMojo.java

...
    private void populateModulesMenuItemsFromModels( List models, Menu menu )
    {
        if ( models != null && models.size() > 1 )
        {
            Iterator reactorItr = models.iterator();

            while ( reactorItr.hasNext() )
            {
                Model model = (Model) reactorItr.next();

                String reactorUrl = model.getUrl();
                String name = model.getName();

                appendMenuItem( menu, name, reactorUrl, model.getArtifactId() );
            }
        }
    }
...

A single project is attached, for testing purposes.

No errors when omitting '--non-recursive' flag:

mvn clean site

Issue Links

• relates to: MSITE-129 modules list empty if modules don't use this project as parent in reactor build