[MSHARED-980] Xpp3DomBuilder does not handle XML encoding per spec

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: maven-shared-utils
• Assignee: Unassigned
• Reporter: Elliotte Rusty Harold
• Created: 26/Feb/21 14:18
• Updated: 04/Dec/21 20:28

Description

Properly handled, there is never any need to specify the character encoding when reading an XML document. XML documents fully identify their character encoding. The developer at this level doesn't need to know and shouldn't think about the character encoding.

 

That is, these methods are wrong:

 

```

public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String encoding )

public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String encoding, boolean trim )

```

 

There should be no encoding argument. Instead the XML should be read from an InputStream without converting it to a reader first. Let the XML parser detect the encoding.