[MSHARED-864] Refactor and simplify code

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Affects Version/s: maven-artifact-transfer-0.13.0
• Fix Version/s: maven-artifact-transfer-0.13.0, maven-artifact-transfer-0.13.1
• Component/s: maven-artifact-transfer
• Assignee: Karl Heinz Marbaise
• Reporter: Karl Heinz Marbaise
• Created: 13/Mar/20 19:28
• Updated: 20/Dec/20 23:15
• Resolved: 04/Apr/20 16:49

Description

• In the classes Maven30DependencyResolver.java, Maven31DependencyResolver.java code can be cleaned up.
  • The code calls setDependencies( List<Dependency> dependencies ) of CollectRequest which allows to give null

• Refactoring in Invoker.java
  • Remove not used methods.
  • Inlining only locally called methods.
  • Move the SuppressWarnings to the invoke methods only; Not in user code (outside of Invoker classes)
  • Make code comment requirements to code requirements (number of elements in argClasses ands args)
  • Using generics removes the need of type casts in user code (outside Invoker classes)
• Simplify catching exceptions (
• MavenArtifactDeployer interface is not needed to be public.
• MavenDependencyCollector interface is not needed to be public.

Issue Links

• relates to: MSHARED-863 Possible NPEx in Maven30DependencyResolver.resolveDependencies