[MSHARED-815] Maven Archiver: MavenArchiver.addManifestAttribute does not escape empty lines in value

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: maven-archiver-3.4.0
• Component/s: maven-archiver
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 14/Apr/19 09:51
• Updated: 12/Jan/21 00:34

Description

According to https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#name-value-pairs-and-sections

Groups of name-value pairs are known as a "section". Sections are separated from other sections by empty lines.

Therefore empty lines in attribute values lead to invalid manifests and must somehow be escaped.
As this is not done by default in java.util.jar.Attributes.writeMain(...) the method MavenArchiver.addManifestAttribute(...) should either throw an exception in case of empty lines given to parameter value or escape those empty lines somehow (https://github.com/apache/maven-archiver/blob/d454ab3fcd147c0201a14f298cc8f9e1a25ba03e/src/main/java/org/apache/maven/archiver/MavenArchiver.java#L221).

Issue Links

• is related to: JCRVLT-324 In case of a long project description in CDATA the resulting MANIFEST.MF is invalid
• links to: JDK-8222547