[MSHARED-73] Verifier doesn't throw VerificationException upon non-zero exit code of mvn.bat on Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-verifier-1.0
• Fix Version/s: maven-verifier-1.2
• Component/s: maven-verifier
• Environment: Windows XP
• Assignee: Benjamin Bentmann
• Reporter: Benjamin Bentmann
• Created: 17/Sep/08 13:07
• Updated: 24/Oct/08 04:25
• Resolved: 17/Sep/08 13:10

Description

Running the core ITs on a Windows box I got:

Failed tests:
  testitMNG3748(org.apache.maven.integrationtests.MavenITmng3748BadSettingsXmlTest)
  testitMNG3314(org.apache.maven.integrationtests.MavenITmng3314OfflineSnapshotsTest)
  testitMNG3220b(org.apache.maven.integrationtests.MavenITmng3220ImportScopeTest)
  testitMNG2695(org.apache.maven.integrationtests.MavenITmng2695OfflinePluginSnapshotsTest)

Investigation showed these failures were due to the Verifier not detecting the (expected) build failure of the IT. Just like in maven-invoker, the environment variable MAVEN_TERMINATE_CMD needs to be set to quit the entire cmd.exe process and not only mvn.bat.

Issue Links

• is duplicated by: MSHARED-76 Verifier executeGoal method is OS-dependent in case of failure
• is related to: MINVOKER-3 Invoker always returns 0 on Windows due to cmd.exe and exit /b in mvn.bat