Maven Shared Components
  1. Maven Shared Components
  2. MSHARED-7

Add stricter pattern filters to maven-common-artifact-filters

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo.

      If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work.

      The attached patch fixes this problem.

      1. IncludesArtifactFilter.patch
        1.0 kB
        Brian Topping
      2. MNG-2621.patch
        13 kB
        Mark Hobson

        Activity

        Brian Topping created issue -
        Jason van Zyl made changes -
        Field Original Value New Value
        Component/s Artifacts and Repositories [ 11338 ]
        Component/s Artifacts [ 12035 ]
        Jason van Zyl made changes -
        Patch Submitted [Yes]
        Jason van Zyl made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Brett Porter made changes -
        Assignee Jason van Zyl [ jason ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Brett Porter made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Won't Fix [ 2 ]
        Mark Hobson made changes -
        Attachment MNG-2621.patch [ 27995 ]
        John Casey made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Won't Fix [ 2 ]
        John Casey made changes -
        Fix Version/s 2.0.x [ 13141 ]
        Component/s Shared [ 12784 ]
        Component/s Artifacts and Repositories [ 11338 ]
        Patch Submitted [Yes]
        Description There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo.

        If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work.

        The attached patch fixes this problem.
        There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo.

        If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work.

        The attached patch fixes this problem.
        John Casey made changes -
        Assignee Jason van Zyl [ jason ] John Casey [ jdcasey ]
        Mark Hobson made changes -
        Summary IncludesArtifactFilter in maven-artifact should accept wildcards Add stricter pattern filters to maven-common-artifact-filters
        Assignee John Casey [ jdcasey ] Mark Hobson [ mihobson ]
        Mark Hobson made changes -
        Fix Version/s Shared Components [ 13561 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 2.0.x [ 13141 ]
        Status Reopened [ 4 ] Closed [ 6 ]
        Siveton Vincent made changes -
        Component/s Shared [ 12784 ]
        Component/s maven-common-artifact-filters [ 13269 ]
        Key MNG-2621 MSHARED-7
        Fix Version/s Shared Components [ 13561 ]
        Project Maven 2 [ 10500 ] Maven Shared Components [ 11761 ]
        Jerome Lacoste made changes -
        Link This issue relates to MWEBSTART-45 [ MWEBSTART-45 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 13:14:21 UTC 2015 [ 1428239661755 ]
        Mark Thomas made changes -
        Workflow jira [ 12726013 ] Default workflow, editable Closed status [ 12764576 ]
        Mark Thomas made changes -
        Project Import Mon Apr 06 01:15:59 UTC 2015 [ 1428282959282 ]
        Mark Thomas made changes -
        Workflow jira [ 12963844 ] Default workflow, editable Closed status [ 13000117 ]

          People

          • Assignee:
            Mark Hobson
            Reporter:
            Brian Topping
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development