Details

      Description

      The current href validation causes several issues, e.g., MSHARED-609, or just the fact that we are not able to properly validate valid links/hrefs because there is a too broad variety of schemes and styles. We can use at most java.net.URI, but still HTML's href is far more permissive. At the end, we drop valid values like ssh://, sftp://, smb://, s3://, and many more without even telling the user.

      We shall stop doing that and simply pass the value as-is, the href is now at the discretion of the site author.

        Issue Links

          Activity

          Hide
          michael-o Michael Osipov added a comment -

          Hervé Boutemy, do you have an opinion or objection on that?

          Show
          michael-o Michael Osipov added a comment - Hervé Boutemy , do you have an opinion or objection on that?
          Hide
          michael-o Michael Osipov added a comment -

          Fixed with r1781702.

          Show
          michael-o Michael Osipov added a comment - Fixed with r1781702 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-shared #3594 (See https://builds.apache.org/job/maven-shared/3594/)
          MSHARED-611 Drop any href validation and pass as-is (michaelo: http://svn.apache.org/viewvc/?view=rev&rev=1781702)

          • (edit) maven-reporting-impl/pom.xml
          • (edit) maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
          • (delete) maven-reporting-impl/src/main/java/org/apache/maven/reporting/UrlValidationUtil.java
          • (delete) maven-reporting-impl/src/test/java/org/apache/maven/reporting/UrlValidationUtilTest.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-shared #3594 (See https://builds.apache.org/job/maven-shared/3594/ ) MSHARED-611 Drop any href validation and pass as-is (michaelo: http://svn.apache.org/viewvc/?view=rev&rev=1781702 ) (edit) maven-reporting-impl/pom.xml (edit) maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java (delete) maven-reporting-impl/src/main/java/org/apache/maven/reporting/UrlValidationUtil.java (delete) maven-reporting-impl/src/test/java/org/apache/maven/reporting/UrlValidationUtilTest.java

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development