[MSHARED-609] Partially revert MSHARED-429

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-reporting-impl 2.4
• Fix Version/s: maven-reporting-impl 3.0
• Component/s: maven-reporting-impl
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 07/Jan/17 16:32
• Updated: 04/Feb/17 20:16
• Resolved: 04/Feb/17 20:16

Description

MSHARED-429 introduced handling of hostnames endling with .local though they are invalid in the way they are used.

Copied from the ticket:
I'd seriously like to revert this partially for 3.0:

• Your DNS setup is simply broken. .local is a reserved TLD for mDNS resolution. This is not meant to be used in private networks. Doing so breaks Avahi on Linux/FreeBSD, Bonjour on macOS and everything else using zeroconf. You should register a domain name and use subdomains on your private network (https://de.wikipedia.org/wiki/Zeroconf#Multicast_DNS).
• It does not accept full 16-bit unsigned integer
• You always have to update with the newest pattern in Commons Validator

Local hostnames (unqualified) can be validated by passing an option/flag to the validator. The rest of the patch, missing TLDs, etc. are already in Commons Validator 1.5.1.

We should not encourage bad setups.

Issue Links

• is part of: MSHARED-611 Drop any href validation and pass as-is
• relates to: VALIDATOR-412 No options for Pseudo TLD
• requires: VALIDATOR-411 UrlValidator accepts ports above max limit of 16-bit unsigned integer
• supercedes: MSHARED-429 Supposedly invalid URLs are rendered as plain text