[MSHARED-608] Remove index.html-adding block in AbstractMavenReportRenderer#getValidHref()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-reporting-impl 2.4
• Fix Version/s: maven-reporting-impl 3.0
• Component/s: maven-reporting-impl
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 07/Jan/17 14:12
• Updated: 07/Jan/17 14:36
• Resolved: 07/Jan/17 14:18

Description

If URL validation fails, the following is executed:

String hrefTmp;
if ( !href.endsWith( "/" ) )
{
  hrefTmp = href + "/index.html";
}
else
{
  hrefTmp = href + "index.html";
}

if ( UrlValidationUtil.isValidUrl( hrefTmp ) )
{
  return href;
}

There are several problems here:

• The assumption that / will point to index.html is wrong. This is not known. It can ultimately lead to 404. No assumption shall be made to the target.
• There is no way that if a URL is already invalid it will get a valid URL by adding index.html.

Remove this code block.